Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Add missing event emitters to internal node properties #5343

Open
wants to merge 1 commit into
base: 8.3
Choose a base branch
from
Open

BUGFIX: Add missing event emitters to internal node properties #5343

wants to merge 1 commit into from
+14 −1

Conversation

Benjamin-K
Copy link
Contributor

Review instructions

Currently, when using the event log, internal node data is not logged. So whenever an internal property like _hiddenBeforeDateTime is changed, you can't see that property in the event log. Therefore, this PR adds missing event emitters to the methods used to set the internal properties.

resolved: #3284

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@Benjamin-K
Copy link
Contributor Author

By looking into the Code: Shouldn't we also log an event, whenever PublishingService::emitNodeDiscarded($node, $baseWorkspace) is emitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Benjamin-K